Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor everything! #22

Closed
rossGardiner opened this issue Apr 6, 2022 · 0 comments
Closed

Refactor everything! #22

rossGardiner opened this issue Apr 6, 2022 · 0 comments
Assignees
@rossGardiner @Saweenbarra @charger4241 @albanjoseph
Labels
enhancement New feature or request
Milestone
Final release - v3.0

Comments

@rossGardiner
Copy link
Collaborator

rossGardiner commented Apr 6, 2022 •
edited
Loading

As the code-base has matured, it's now time to refactor and clean up some of the mess we've left. This includes:

  • Consistent file formatting across all code files (can made consistent easily with an IDE and some shortcuts)
  • Removing code which executes the legacy video processing pipeline
  • File structure
    • Currently gui/ images/ and models/ could all go into a directory assets/ as is standard (I think)
  • Remove commented out lines, debugging statements, simplify functions throughout
  • Rename some files and classes, a consistent style with capital letters would be nice, suggested style:
    • Camel case is always used
    • Capital letter begins a class, public method or property and a filename
    • Lower-case letter begins everything else
@rossGardiner rossGardiner added the enhancement New feature or request label Apr 6, 2022
@rossGardiner rossGardiner added this to the Final release - v3.0 milestone Apr 6, 2022
rossGardiner added a commit that referenced this issue Apr 6, 2022
@rossGardiner
SOLID refactoring and tidy #24 #22
98446fe
rossGardiner added a commit that referenced this issue Apr 7, 2022
@rossGardiner
adds type safe bounding box, scene editor work, #22 #24
ff2b764
rossGardiner added a commit that referenced this issue Apr 7, 2022
@rossGardiner
refactoring video processing, #22
4a4a390
rossGardiner added a commit that referenced this issue Apr 7, 2022
@rossGardiner
remove drawBox override, #22
607a7be
rossGardiner added a commit that referenced this issue Apr 7, 2022
@rossGardiner
quick tidy, spacing and types, #22
977bfca
rossGardiner added a commit that referenced this issue Apr 7, 2022
@rossGardiner
adds flip frame functionality #22 #24
c5de8d2
rossGardiner added a commit that referenced this issue Apr 7, 2022
@rossGardiner
removes dataReady function, #22
8d43100
rossGardiner added a commit that referenced this issue Apr 8, 2022
@rossGardiner
Removes apt update and upgrade, #22
7c5816d
rossGardiner added a commit that referenced this issue Apr 8, 2022
@rossGardiner
includes new, schedulable pipeline, #22 #24
1abfaad
rossGardiner added a commit that referenced this issue Apr 8, 2022
@rossGardiner
simplifies schedulable interface #22 #24
6bbd369
@rossGardiner rossGardiner mentioned this issue Apr 8, 2022
Merged
rossGardiner added a commit that referenced this issue Apr 9, 2022
@rossGardiner
adds doubler #22 #24
0ab8bf8
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
remove batch processing from main #22 #24
d3cea4b
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
SceneEditor -> PreProcessor, #22
50a7937
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
camera -> Camera, #22
8d30ba3
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
fix build, #22
914f048
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
scene -> Scene, #22
fb2c36c
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
SceneEditorSettings -> PreProcessorSettings, #22
70f1618
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
Delete taskMaster.h
3a907e1 
#22
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
Delete taskmaster.h
79f774c 
#22
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
Delete taskmaster.cpp
c4b108e 
#22
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
Delete taskMaster.h.gch
0ebbeae 
#22
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
fix build, #22
21fced5
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
adds thread destructors, #22 #24
e9ee51b
This was referenced Apr 12, 2022
Merged
Merged
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
Delete SceneLinkScheduler.h
894be64 
#22
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
Delete SceneLinkScheduler.cpp
bc65337 
#22
rossGardiner added a commit that referenced this issue Apr 12, 2022
@rossGardiner
Update CMakeLists.txt
3cbd309 
#22
rossGardiner added a commit that referenced this issue Apr 13, 2022
@rossGardiner
refactors CMakeLists, #22
fd0e0a6
rossGardiner added a commit that referenced this issue Apr 13, 2022
@rossGardiner
resolves segfault upon exit, refactors, #24, #22
7ed6eb1
@rossGardiner rossGardiner mentioned this issue Apr 13, 2022
Merged
rossGardiner added a commit that referenced this issue Apr 13, 2022
@rossGardiner
Delete gtest_linksplitter.h
0f0d040 
#22
rossGardiner added a commit that referenced this issue Apr 13, 2022
@rossGardiner
Update README.md
981941a 
#22
rossGardiner added a commit that referenced this issue Apr 14, 2022
@rossGardiner
adds docstrings, refactors SignapseUtils, #22, #11
38e9f2c
rossGardiner added a commit that referenced this issue Apr 15, 2022
@rossGardiner
adds camera settings object #22
5c3df65
rossGardiner added a commit that referenced this issue Apr 15, 2022
@rossGardiner
fixes random seed bug #22
414b4f4
rossGardiner added a commit that referenced this issue Apr 18, 2022
@rossGardiner
Delete NThreadedCNNProcessor.h
051c0bf 
#22
rossGardiner added a commit that referenced this issue Apr 18, 2022
@rossGardiner
Delete NThreadedCNNProcessor.cpp
19b3bc9 
#22
rossGardiner added a commit that referenced this issue Apr 18, 2022
@rossGardiner
Delete MultiThreadedSchedulableLink.h
69b0db9 
#22
rossGardiner added a commit that referenced this issue Apr 18, 2022
@rossGardiner
Delete MultiThreadedSchedulableLink.cpp
116feb3 
#22
rossGardiner added a commit that referenced this issue Apr 18, 2022
@rossGardiner
Delete BatchCNNProcessor.cpp
87d306f 
#22
rossGardiner added a commit that referenced this issue Apr 18, 2022
@rossGardiner
Delete BatchCNNProcessor.h
5bff231 
#22
rossGardiner added a commit that referenced this issue Apr 18, 2022
@rossGardiner
fixes build after refactor #22
8027239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossGardiner rossGardiner

@Saweenbarra Saweenbarra

@charger4241 charger4241

@albanjoseph albanjoseph

Labels
enhancement New feature or request
Projects
None yet
Milestone
Final release - v3.0
Development

No branches or pull requests
4 participants
@rossGardiner @Saweenbarra @charger4241 @albanjoseph