Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventStore.getConsumer returning Consumer instance #173

Merged
merged 1 commit into from
Jun 12, 2021
Merged

Conversation

albe
Copy link
Owner

@albe albe commented Jun 12, 2021

This change removes the EventUnwrapper transform stream from EventStore.getConsumer(), which made the method return a stream.Transform instead of an instance of Consumer.
This means that the Consumer from an EventStore receives stored event structures, which constist of { stream: string, payload: object, metadata: object }, where payload corresponds to the original event that was committed.

Resolves #172

@albe albe added bug P: EventStore Affects the EventStore layer labels Jun 12, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 97.718% when pulling 38a5694 on consumer-fixes into 8a6d93a on main.

@albe albe added this to In progress in 0.9 Jun 12, 2021
@albe albe merged commit 8ea608f into main Jun 12, 2021
@albe albe deleted the consumer-fixes branch June 12, 2021 15:47
@albe albe moved this from In progress to Done in 0.9 Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P: EventStore Affects the EventStore layer
Projects
0.9
Done
Development

Successfully merging this pull request may close these issues.

EventStore.getConsumer does not return a Consumer instance
2 participants