Version 1.0.9 update #222
Merged
Version 1.0.9 update #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
enryH
commented
Sep 20, 2020
•
enryH
commented
- add Embedding Layer (PR feature/embedding layer lrp #115 and Pr/115 #212 )
- make BatchNormalization LRP compatible: commit
- gitHub Actions GitHub action tf1 #210
- fix example notebooks: Some DeepLIFT bugfixes #195, Update introduction_development.ipynb #164, Update utils_imagenet.py #147
- old small bug fixes
import from innvestigate.analyzer.base
…ametrized) layers until a given index
Not "_deep_lift_func"
Fixing typo
Fix DeepLIFT bugfixes
Fix import of ReverseAnalyzerBase
Added LRP-analyzer class to allow application of LRP_flat on all (parametrized) layers until a given index
|
In relevance_rule.py new alpha-beta-rules are introduced in Feb. 2019. Is there any reference? "AlphaBetaXRule",
"AlphaBetaX1000Rule",
"AlphaBetaX1010Rule",
"AlphaBetaX1001Rule",
"AlphaBetaX2m100Rule" |
albermax
approved these changes
Sep 25, 2020
.github/workflows/pythonapp.yml
Outdated
| flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics | ||
| # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide | ||
| flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics | ||
| # or pylint? |
There was a problem hiding this comment.
So you suggest removing the flake8 part?
| @@ -44,7 +44,7 @@ def readme(): | |||
| def setup(): | |||
| setuptools.setup( | |||
| name="innvestigate", | |||
| version="1.0.8", | |||
| version="1.0.9", | |||
There was a problem hiding this comment.
I suggest you update the authors below. At least you contributed too.
| model.add(Dense(16, activation='relu')) | ||
| model.add(Dense(2, activation=None)) | ||
|
|
||
| # print(model.layers[0].get_weights()[0].shape) |
|
v1.0.9 is now on test.pypi.org for testing. |
|
Yes, if it is not used I would remove it.
…On Fri, Sep 25, 2020 at 11:54 AM Henry ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/pythonapp.yml
<#222 (comment)>:
> + uses: ***@***.***
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ run: |
+ python -m pip install --upgrade pip
+ pip install .
+ pip install tensorflow==${{matrix.tensorflow-version}} matplotlib
+ - name: Lint with flake8
+ run: |
+ pip install flake8
+ # stop the build if there are Python syntax errors or undefined names
+ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+ # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+ flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+ # or pylint?
So you suggest removing the flake8 part?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#222 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADBDPJ5RX4BIKBBF6NYLHD3SHRSGZANCNFSM4RTQNJXA>
.
--
Cheers,
Max
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.