Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chasquid-util aliases-resolve does not take hooks into account #18

Closed
albertito opened this issue Feb 5, 2021 · 1 comment
Closed

chasquid-util aliases-resolve does not take hooks into account #18

albertito opened this issue Feb 5, 2021 · 1 comment
Assignees
@albertito
Labels
bug

Comments

@albertito
Copy link
Owner

This is forked from issue #17, where @DiederikvandenB reported that chasquid-util aliases-resolve does not take hooks into account, and that is confusing and misleading.

At minimum, the documentation should mention this fact, and possibly a warning should be emitted if the hooks are present.

There is no way to manually do an alias resolution with hooks for troubleshooting (other than sending an email, of course), which should also be fixed.
@albertito albertito self-assigned this Feb 5, 2021
@albertito albertito added the bug label Feb 5, 2021
@albertito albertito mentioned this issue Feb 5, 2021
Closed
albertito added a commit that referenced this issue Jul 30, 2023
@albertito
chasquid-util: Use server for aliases-resolve and domaininfo-remove
377e0f9 
This patch makes chasquid-util's aliases-resolve and domaininfo-remove
commands talk to the chasquid server (via the new localrpc server).

For aliases-resolve, currently has fairly hacky logic which reimplements
a bunch of the servers', and is also incomplete because it does not
support hooks.

In this patch we fix that by having it talk to the server, where we get
authoritative responses and have no issues with aliases hooks. This
resolves #18.

For domaininfo-remove, currently its implementation is also very hacky
since it manipulates files behind the servers' back and without even
using the internal library.

In this patch we fix that by doing the operation through the server,
avoiding the need for those hacks, and also remove the need to manually
reload the server afterwards.
albertito added a commit that referenced this issue Jul 30, 2023
@albertito
chasquid-util: Use server for aliases-resolve and domaininfo-remove
e6c6df4 
This patch makes chasquid-util's aliases-resolve and domaininfo-remove
commands talk to the chasquid server (via the new localrpc server).

For aliases-resolve, currently has fairly hacky logic which reimplements
a bunch of the servers', and is also incomplete because it does not
support hooks.

In this patch we fix that by having it talk to the server, where we get
authoritative responses and have no issues with aliases hooks. This
resolves #18.

For domaininfo-remove, currently its implementation is also very hacky
since it manipulates files behind the servers' back and without even
using the internal library.

In this patch we fix that by doing the operation through the server,
avoiding the need for those hacks, and also remove the need to manually
reload the server afterwards.
@albertito
Copy link
Owner Author

This is fixed in the next branch: chasquid-util now asks the running daemon to resolve the alias, so the answer will be authoritative and inclusive of any hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertito albertito

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@albertito