Set Yadda options

[benwalder]

This replaces #42, and is intended to be rolled into 0.4.0.

It allows options for Yadda to be passed through from ember-cli-build.js:

module.exports = function(defaults) {
  let app = new EmberApp(defaults, {

    'ember-cli-yadda': {
      yaddaOptions: { // passed through to yadda parseFeature()
        language: 'Polish', // converted to Yadda.localisation.Polish
        leftPlaceholderChar: '<',
        rightPlaceholderChar: '>'
      }

    }
  });

The language string is converted to a yadda localisation module in ember-cli-yadda's feature parser b/c it was an easy place to insert it (yadda is available here). It could probably go somewhere is if this doesn't seem right.

The location of the Yadda Configuration section in the readme file will need to be changed when #71 is merged, so this is currently WIP.

[albertjan]

LGTM

[simonihmig]

👍

[benwalder]

Rebased.

Looks like my editor did a bunch of white space changes in README.md, 😞 hiding the real change at the bottom.

I bumped the version to 0.4.0 in anticipation of publishing soon. 🎉

How does setting the language by passing options to the featureParser work with setting English on the library in steps.js? This needs a bit of investigation before merging. ❓

[simonihmig]

How does setting the language by passing options to the featureParser work with setting English on the library in steps.js? This needs a bit of investigation before merging. ❓

Yeah, good catch!

I think I didn't modify anything related to the localization feature compared to the previous blueprints. And I don't know off-hand how this should look like, but indeed this seems to need to be fixed!

[benwalder]

The language set for featureParser is used to parse the .feature files. The language set for the library is used to parse the *-steps.js files. Most likely these should match.

With this latest change, the language may be configured in ember-cli-build.js and then is used for both the featureParser and the *-steps.js files. At build time, the configured language is:

• converted to the Language object and passed to the featureParser
• used to override the yadda default language (as suggested) in the generated test code, so at run time it will be used by step libraries (which are set to use the default)

I have manually tested the qunit side, but not mocha. Also need to consider how to add any automated tests.

[simonihmig]

LGTM!

[simonihmig]

Uh, how did I miss that? Good catch!

[simonihmig]

I have manually tested the qunit side, but not mocha. Also need to consider how to add any automated tests.

Absolutely! As my app was using Mocha, I tested the changes I did recently using an npm link, but in general this is certainly bad that were kind of blind on one eye. 🤔 I created #73 to track this...

[benwalder]

@albertjan @simonihmig Ready to merge and publish 0.4.0?

[simonihmig]

Yes, go for it! 🎉

[albertjan]

Nice one guys! Does one of you want to do the release tweet? Scream and shout about what we've done 😛?

[benwalder]

0.4.0 is published. Edit release notes as you see fit. Thanks for your work on this! One of you please do the tweeting.

[simonihmig]

@sfbwalder I changed your release description a bit. It don't think that this does not work with Ember 2.x anymore! AFAIK it is not related to any Ember version at all. For example I maintain ember-bootstrap, that has its test written with the new testing APIs, and it is tested with ember-try down to Ember 2.3! You just have to use the new setup functions and use the test helpers from @ember/test-helpers.

In the case of Mocha I think you could even rewrite your annotations to use Mocha's old setup functions, and use this addon this way with the old testing setup. In case of QUnit, that's maybe also somehow possible, but not as easy as we cannot use the custom moduleFor... functions anymore, as module() is hardcoded in the test runner...

Just for clarification ;)

[simonihmig]

Nice one guys! Does one of you want to do the release tweet? Scream and shout about what we've done 😛?

The privilege belongs to the maintainer I think!? 😉
But if you prefer, I can certainly do that as well...

[benwalder]

it is tested with ember-try down to Ember 2.3!

😳 😫 😬 duh, thanks for the fix.

[albertjan]

The privilege belongs to the maintainer I think!? 😉
But if you prefer, I can certainly do that as well...

haha, you guys did all the work! I'll retweet! 😄