Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rpath for dependent libs #442

Closed
wants to merge 2 commits into from
Closed

Conversation

bebehei
Copy link
Contributor

@bebehei bebehei commented Apr 14, 2017

Fixes #437

Before merging this PR: Why is an additional runpath not needed for the plugins, although these require globalshortcut and xdg directly?

@ManuelSchneid3r
Copy link
Member

Globalshortcut should not need it. Since it has no dependencies. Well I have no clue why the extensions dont need it. Maybe RPATH gets inherited by the linking elf.

@bebehei
Copy link
Contributor Author

bebehei commented Apr 14, 2017

bebe@ubuntu17:~$ ldd /usr/local/lib/albert/plugins/libfirefoxbookmarks.so | grep found
        libalbertcore.so => not found
        libxdg.so => not found

But running it with albert spits no errors and it works fine.

@ManuelSchneid3r
Copy link
Member

ManuelSchneid3r commented Apr 14, 2017

damn this pr is screwed up now. well ill set this for the plugins too. thank you for your investigatuions benedikt. merged manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants