Fix crashes on Wayland by not loading the HotkeyManager #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2019 12:59
On Wayland, global hotkeys are often handled by the compositor instead. On sway for instance, a config file is edited to launch specific commands when a hotkey is entered. On such compositors, it should be enough to show Albert by configuring the compositor to launch "albert show" or "albert toggle" a hotkey manager in Albert itself is redundant.
|
Confirming problem, I just installed albert and it's crashing at startup: |
|
I built Albert with this patch and it fixes the crash at startup under Sway. |
edrex
approved these changes
Nov 25, 2019
| if ( !hotkeyManager->registerHotkey(hotkey) ) | ||
| qFatal("Failed to set hotkey to %s.", hotkey.toLocal8Bit().constData()); | ||
|
|
||
| if ( !QGuiApplication::platformName().contains("wayland") ) |
There was a problem hiding this comment.
I thought about whether this is the right thing in all wayland environments, and I think it is. I'm not aware of a wayland protocol for requesting a hotkey from the compositor, and if there is it can be supported in a later patch.
|
@ManuelSchneid3r this LGTM. |
This was referenced Nov 25, 2019
Closed
|
Is something holding this back? I also get albert failing to start on my sway env and I would appreciate ii if this was merged! Thanks! |
idkCpp
reviewed
Feb 18, 2020
| this, &SettingsWidget::changeHotkey); | ||
| } else { | ||
| ui.grabKeyButton_hotkey->setVisible(false); | ||
| ui.label_hotkey->setVisible(false); |
There was a problem hiding this comment.
Design choice:
- Just hide it
- Tell the user that it can't be done this way and that they should consult the compositor
I personally would go with option 2
There was a problem hiding this comment.
You mean like a dialog when you push the button, or a tooltip on a disabled button?
Maybe it can be done separately in another merge request? I'm not sure when I have the time to continue work on this, and in the meantime it would be nice to at least solve the crashes :)
|
I'm not sure if this fix is missing something, but I'm running on Fedora 31 and the fix doesn't seem to work for me, I'm still seeing a core dump Let me know if I can provide any other testing or information. |
|
Running into this on a fresh Fedora 31 system. Is there something holding this back from being merged? debug info |
|
UPDATE 2: Building from the right branch allows albert to go through first run, but when actually trying to use it... $ albert -r$ albert$ coredumpctl infoUPDATE: I'm an idiot. I was in master. Had to pull the right branch.
Disregard the below. Hmm. Built albert from Still segfaults. $ albert -v
$ albert$ coredumpctl infoI'm not smart enough to know if it is the same crash you were trying to fix or something different. |
|
Any news when this will merge? |
|
BUMP. Also having this issue on sway, installed from the OBS repo. |
|
Any idea when this will be merged? |
|
I also needed albertlauncher/plugins#21 to fix the widgetboxmodel plugin (otherwise it crashed on |
ManuelSchneid3r
pushed a commit
that referenced
this pull request
Nov 22, 2020
* Fix crashes on Wayland by not loading the HotkeyManager On Wayland, global hotkeys are often handled by the compositor instead. On sway for instance, a config file is edited to launch specific commands when a hotkey is entered. On such compositors, it should be enough to show Albert by configuring the compositor to launch "albert show" or "albert toggle" a hotkey manager in Albert itself is redundant. * Fix crash when exiting settings Co-authored-by: Johan Klokkhammer Helsing <johan.helsing@qt.io>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Wayland, global hotkeys are often handled by the compositor instead. On sway
for instance, a config file is edited to launch specific commands when a hotkey
is entered.
On such compositors, it should be enough to show Albert by configuring the
compositor to launch "albert show" or "albert toggle" a hotkey manager in
Albert itself is redundant.