refactor(time_of_day_extension): improve comparison implementation

albertms10 · Sep 18, 2021 · cfe1aba · cfe1aba
1 parent 617c4a6
commit cfe1aba
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/utils/time_of_day_extension.dart b/lib/utils/time_of_day_extension.dart
@@ -22,13 +22,18 @@ extension TimeOfDayExtension on TimeOfDay {
 
   static int compare(TimeOfDay a, TimeOfDay b) => a.compareTo(b);
 
+  int get inMinutes => hour * TimeOfDay.minutesPerHour + minute;
+
+  int compareTo(TimeOfDay? other) {
+    if (other == null) return 1;
+    if (other == this) return 0;
+    return inMinutes.compareTo(other.inMinutes);
+  }
+
   Duration durationBetween(TimeOfDay other) => Duration(
         hours: other.hour - hour,
         minutes: other.minute - minute,
       );
 
   String format24Hour() => '${hour.padLeft2}:${minute.padLeft2}';
-
-  int compareTo(TimeOfDay other) =>
-      (hour - other.hour) * 60 + minute - other.minute;
 }