refactor(model): improve == and hashCode methods (#134)

albertms10 · Dec 8, 2022 · e1ad57e · e1ad57e
1 parent 6b2c6f0
commit e1ad57e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/src/model/date/date_range_item.dart b/lib/src/model/date/date_range_item.dart
@@ -58,12 +58,13 @@ class DateRangeItem extends Item with DateRanger {
 
   @override
   bool operator ==(Object other) =>
+      super == other &&
       other is DateRangeItem &&
       startDate == other.startDate &&
       endDate == other.endDate;
 
   @override
-  int get hashCode => Object.hash(startDate, endDate);
+  int get hashCode => Object.hash(super.hashCode, startDate, endDate);
 
   @override
   int compareTo(covariant DateRangeItem other) =>

diff --git a/lib/src/model/date/holiday.dart b/lib/src/model/date/holiday.dart
@@ -23,6 +23,13 @@ class Holiday extends DateRangeItem {
         ...super.toJson(),
         _JsonFields.kind: kind.index,
       };
+
+  @override
+  bool operator ==(Object other) =>
+      super == other && other is Holiday && kind == other.kind;
+
+  @override
+  int get hashCode => Object.hash(super.hashCode, kind.hashCode);
 }
 
 enum HolidayKind { festivity, freeDisposal }