Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(booking): extend DateRangeItem #133

Merged
merged 2 commits into from
Dec 6, 2022
Merged

refactor(booking): extend DateRangeItem #133

merged 2 commits into from
Dec 6, 2022

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Dec 6, 2022 •
edited
Loading

This PR aims to reuse DateRangeItem members already existing in the Booking class by making it extend the former.

@albertms10 albertms10 added the refactor The code needs to be refactored label Dec 6, 2022
@albertms10 albertms10 self-assigned this Dec 6, 2022
@coveralls
Copy link
Collaborator

coveralls commented Dec 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3631527922

  • 0 of 7 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 24.67%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/model/booking/single_booking.dart 0 2 0.0%
lib/src/model/date/date_range_item.dart 0 2 0.0%
lib/src/model/booking/recurring_booking.dart 0 3 0.0%
Totals Coverage Status
Change from base Build 3631432993: 0.1%
Covered Lines: 262
Relevant Lines: 1062
💛 - Coveralls

@albertms10 albertms10 merged commit 6b2c6f0 into main Dec 6, 2022
@albertms10 albertms10 deleted the refactor/booking-extends-date-rage-item branch December 6, 2022 16:42
@albertms10 albertms10 added this to the Version 0.7 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored
Projects
None yet
Milestone
Version 0.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls