Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(holiday)!: extend DateRange instead of DateRangeItem #153

Merged
merged 3 commits into from Dec 25, 2022
Merged

refactor(holiday)!: extend DateRange instead of DateRangeItem #153

merged 3 commits into from Dec 25, 2022

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Dec 25, 2022 •
edited

Breaking change: The Holiday class will no longer be considered a descendant of Item, and will instead be inheriting the standalone DateRange class, meaning it will lose all Item specific properties—such as a unique ID and creation and modification information.

This PR also makes DateRange implement Comparable and Serializable interfaces.

@albertms10 albertms10 added the refactor The code needs to be refactored label Dec 25, 2022
@albertms10 albertms10 self-assigned this Dec 25, 2022
@albertms10 albertms10 changed the title refactor(holiday): extend DateRange instead of DateRangeItem refactor(holiday)!: extend DateRange instead of DateRangeItem Dec 25, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3775951410

  • 10 of 13 (76.92%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 31.793%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/model/school_year/school_year.dart 0 1 0.0%
lib/src/model/date/date_range.dart 7 9 77.78%
Totals Coverage Status
Change from base Build 3768837199: 0.4%
Covered Lines: 351
Relevant Lines: 1104
💛 - Coveralls

@albertms10 albertms10 merged commit 9e5852c into main Dec 25, 2022
@albertms10 albertms10 deleted the refactor/holiday-extends-date-range branch December 25, 2022 13:05
@albertms10 albertms10 added this to the Version 0.8 milestone Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored
Projects
None yet
Milestone
Version 0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls