Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(date_ranger): implement new textualDateTime methods #168

Merged
merged 6 commits into from Jan 6, 2023
Merged

feat(date_ranger): implement new textualDateTime methods #168

merged 6 commits into from Jan 6, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Jan 6, 2023 •
edited

This PR aims to replace the timeRange and dateTimeRange methods from Booking with textualTime and textualDateTime in DateRanger, allowing custom date and time formats.

Additionally, the TimeOfDayExtension.format24hour method has been removed.

@albertms10 albertms10 added enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests labels Jan 6, 2023
@albertms10 albertms10 added this to the Version 0.8 milestone Jan 6, 2023
@albertms10 albertms10 self-assigned this Jan 6, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 6, 2023 •
edited

Pull Request Test Coverage Report for Build 3858763578

  • 25 of 26 (96.15%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 35.326%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/model/booking/booking.dart 0 1 0.0%
Totals Coverage Status
Change from base Build 3813477558: 1.5%
Covered Lines: 396
Relevant Lines: 1121
💛 - Coveralls

@albertms10 albertms10 merged commit a46353b into main Jan 6, 2023
@albertms10 albertms10 deleted the feat/implement-new-date-range-textual-date-time-methods branch January 6, 2023 22:15
albertms10 added a commit that referenced this pull request Jan 6, 2023
@albertms10
fix(booking): call textualDateTime method on toString
d343c10 
Addresses an issue introduced in #168
@albertms10 albertms10 mentioned this pull request Jan 6, 2023
Merged
albertms10 added a commit that referenced this pull request Jan 7, 2023
@albertms10
fix(booking): call textualDateTime method on toString (#170)
35a4ae2 
* fix(booking): call `textualDateTime` method on `toString`

Addresses an issue introduced in #168

* fix(booking): ensure to always display the year textually

* test(single_booking): add test cases for `toString` method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
Version 0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls