Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rename Manager → Collection #169

Merged
merged 1 commit into from Jan 6, 2023
Merged

refactor!: rename Manager → Collection #169

merged 1 commit into from Jan 6, 2023

Conversation

albertms10
Copy link
Owner

Breaking change: rename collection file names:

  • CabinManager.fileName: cabin_manager → cabins
  • SchoolYearManager.fileName: school_year_manager → school_years

@albertms10 albertms10 added enhancement New feature or request refactor The code needs to be refactored labels Jan 6, 2023
@albertms10 albertms10 added this to the Version 0.8 milestone Jan 6, 2023
@albertms10 albertms10 self-assigned this Jan 6, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3858964209

  • 6 of 50 (12.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 35.326%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/model/school_year_collection.dart 0 1 0.0%
lib/src/model/cabin_collection.dart 0 3 0.0%
lib/src/model/date/day_handler.dart 0 14 0.0%
lib/src/model/cabin/cabin.dart 4 30 13.33%
Files with Coverage Reduction New Missed Lines %
lib/src/model/date/day_handler.dart 1 0%
Totals Coverage Status
Change from base Build 3858907093: 0.0%
Covered Lines: 396
Relevant Lines: 1121
💛 - Coveralls

@albertms10 albertms10 merged commit da786cc into main Jan 6, 2023
@albertms10 albertms10 deleted the refactor/rename-manager-to-collection branch January 6, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
enhancement New feature or request refactor The code needs to be refactored
Projects
None yet
Milestone
Version 0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls