Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date_ranger): exclude endDate instant in includes #180

Merged
merged 1 commit into from Jan 14, 2023
Merged

fix(date_ranger): exclude endDate instant in includes #180

merged 1 commit into from Jan 14, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Jan 14, 2023 •
edited

This PR aims to exclude the endDate instant in the DateRanger.includes method, as would have been expected as a known convention.

@albertms10 albertms10 added bug Something isn't working test The code needs to implement tests labels Jan 14, 2023
@albertms10 albertms10 added this to the Version 0.8 milestone Jan 14, 2023
@albertms10 albertms10 self-assigned this Jan 14, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3920803873

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 41.417%
Totals Coverage Status
Change from base Build 3920449201: 0.2%
Covered Lines: 456
Relevant Lines: 1101
💛 - Coveralls

@albertms10 albertms10 merged commit f99a8fb into main Jan 14, 2023
@albertms10 albertms10 deleted the fix/exclude-end-date-instant-in-includes branch January 14, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
bug Something isn't working test The code needs to implement tests
Projects
None yet
Milestone
Version 0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls