Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use appropriate variable names for DateRanger #197

Merged
merged 4 commits into from
Feb 14, 2023
Merged

refactor: use appropriate variable names for DateRanger #197

merged 4 commits into from
Feb 14, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Jan 28, 2023 •
edited
Loading

Variables of type DateRanger and DateRangeItem had inconsistent names across the app. This PR consistently renames all members to their appropriate naming.

Furthermore, it replaces declaracions inferring the DateRange type with its supertype DateRanger that is being consumed in tests, providing more visibility on what is tested.

@albertms10 albertms10 added the refactor The code needs to be refactored label Jan 28, 2023
@albertms10 albertms10 added this to the Version 0.9 milestone Jan 28, 2023
@albertms10 albertms10 self-assigned this Jan 28, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4178836377

  • 7 of 25 (28.0%) changed or added relevant lines in 2 files are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 49.53%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/model/booking_collection.dart 7 14 50.0%
lib/src/model/cabin_collection.dart 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
lib/src/model/booking_collection.dart 5 30.13%
lib/src/model/cabin_collection.dart 10 0%
Totals Coverage Status
Change from base Build 4178806149: 0.0%
Covered Lines: 527
Relevant Lines: 1064
💛 - Coveralls

@albertms10 albertms10 merged commit 1004afb into main Feb 14, 2023
@albertms10 albertms10 deleted the refactor/use-correct-variable-names-for-date-ranger branch February 14, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored
Projects
None yet
Milestone
Version 0.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls