Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(booking_collection): rewrite methods using a DateRanger param #198

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Jan 28, 2023

After #132, the DateRanger mixin had a more comprehensible set of methods to operate with. Thus, this PR takes advantage of it by consistently using a DateRanger object for date operations.

@albertms10 albertms10 added the refactor The code needs to be refactored label Jan 28, 2023
@albertms10 albertms10 added this to the Version 0.9 milestone Jan 28, 2023
@albertms10 albertms10 self-assigned this Jan 28, 2023
@albertms10 albertms10 force-pushed the refactor/rewrite-booking-collection-methods-using-date-ranger-param branch from ce14c21 to f5c020a Compare January 28, 2023 10:33
@albertms10 albertms10 changed the title refactor: use appropriate variable names for DateRanger refactor(booking_collection): rewrite methods using a DateRanger param Jan 28, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2023

Pull Request Test Coverage Report for Build 4178645312

  • 6 of 8 (75.0%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.1%) to 49.53%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/model/cabin_collection.dart 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
lib/src/model/cabin_collection.dart 1 0%
lib/src/model/booking/recurring_booking.dart 2 66.67%
lib/src/model/booking_collection.dart 9 30.13%
Totals Coverage Status
Change from base Build 4178560228: -1.1%
Covered Lines: 527
Relevant Lines: 1064

💛 - Coveralls

@albertms10 albertms10 merged commit 5cda40d into main Feb 14, 2023
@albertms10 albertms10 deleted the refactor/rewrite-booking-collection-methods-using-date-ranger-param branch February 14, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor The code needs to be refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants