Merge branch 'main' into fix/address-large-closest-pitch-spellings-fo…

…r-harmonics-with-temperature

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>

lib/src/note/closest_pitch.dart

@@ -69,9 +69,14 @@ class ClosestPitch {
   Frequency frequency({
     TuningSystem tuningSystem = const EqualTemperament.edo12(),
     Celsius temperature = Celsius.reference,
+    Celsius referenceTemperature = Celsius.reference,
   }) =>
       Frequency(
-        pitch.frequency(tuningSystem: tuningSystem, temperature: temperature) *
+        pitch.frequency(
+              tuningSystem: tuningSystem,
+              temperature: temperature,
+              referenceTemperature: referenceTemperature,
+            ) *
             cents.ratio,
       );
 

lib/src/note/frequency.dart

@@ -58,8 +58,11 @@ extension type const Frequency._(num hertz) implements num {
   ClosestPitch closestPitch({
     TuningSystem tuningSystem = const EqualTemperament.edo12(),
     Celsius temperature = Celsius.reference,
+    Celsius referenceTemperature = Celsius.reference,
   }) {
-    final cents = Ratio(at(temperature) / tuningSystem.fork.frequency).cents;
+    final cents = Ratio(
+      at(temperature, referenceTemperature) / tuningSystem.fork.frequency,
+    ).cents;
     final semitones = tuningSystem.fork.pitch.semitones + (cents / 100).round();
 
     final closestPitch = PitchClass(semitones)
@@ -88,7 +91,7 @@ extension type const Frequency._(num hertz) implements num {
   /// See [Change of pitch with change of temperature](https://sengpielaudio.com/calculator-pitchchange.htm).
   ///
   /// ![Effect of a Local Temperature Change in an Organ Pipe](https://sengpielaudio.com/TonhoehenaenderungDurchTemperaturaenderung.gif)
-  Frequency at(Celsius temperature, {Celsius reference = Celsius.reference}) =>
+  Frequency at(Celsius temperature, [Celsius reference = Celsius.reference]) =>
       Frequency(hertz * temperature.ratio(reference));
 
   /// The harmonic at [index] from this [Frequency], including negative

lib/src/note/pitch.dart

@@ -423,9 +423,10 @@ final class Pitch extends Scalable<Pitch> implements Comparable<Pitch> {
   Frequency frequency({
     TuningSystem tuningSystem = const EqualTemperament.edo12(),
     Celsius temperature = Celsius.reference,
+    Celsius referenceTemperature = Celsius.reference,
   }) =>
       Frequency(tuningSystem.fork.frequency * tuningSystem.ratio(this))
-          .at(temperature);
+          .at(temperature, referenceTemperature);
 
   /// Creates a new [TuningFork] from this [Pitch] at a given [frequency].
   ///
@@ -449,6 +450,7 @@ final class Pitch extends Scalable<Pitch> implements Comparable<Pitch> {
     required int upToIndex,
     TuningSystem tuningSystem = const EqualTemperament.edo12(),
     Celsius temperature = Celsius.reference,
+    Celsius referenceTemperature = Celsius.reference,
   }) =>
       frequency(
         tuningSystem: tuningSystem,
@@ -461,6 +463,7 @@ final class Pitch extends Scalable<Pitch> implements Comparable<Pitch> {
                 .closestPitch(
                   tuningSystem: tuningSystem,
                   temperature: temperature,
+                  referenceTemperature: referenceTemperature,
                 )
                 .respelledSimple,
           )

lib/src/tuning/cent.dart

@@ -18,11 +18,14 @@ extension type const Cent(num value) implements num {
   /// The unit symbol for [Cent].
   static const unitSymbol = '¢';
 
+  /// The [Cent] divisions per semitone.
+  static const divisionsPerSemitone = Cent(100);
+
   /// The number of cents in an [Interval.P8].
-  static const octaveCents = Cent(chromaticDivisions * 100);
+  static const octave = Cent(chromaticDivisions * divisionsPerSemitone);
 
   /// The [Ratio] for this [Cent].
-  Ratio get ratio => Ratio(math.pow(2, value / octaveCents));
+  Ratio get ratio => Ratio(math.pow(2, value / octave));
 
   /// This [Cent] formatted as a string.
   ///

lib/src/tuning/ratio.dart

@@ -30,5 +30,5 @@ extension type const Ratio._(num value) implements num {
   /// edo19.ratioFromSemitones(1).cents == const Cent(63.16)
   /// edo19.ratioFromSemitones(10).cents == const Cent(631.58)
   /// ```
-  Cent get cents => Cent(math.log(value) / math.log(2) * Cent.octaveCents);
+  Cent get cents => Cent(math.log(value) / math.log(2) * Cent.octave);
 }

test/src/note/closest_pitch_test.dart

@@ -71,7 +71,7 @@ void main() {
       });
     });
 
-    group('.respellSimple', () {
+    group('.respelledSimple', () {
       test('respells this ClosestPitch to the simplest expression', () {
         expect(ClosestPitch.parse('A4+36').respelledSimple.toString(), 'A4+36');
         expect(