test(closest_pitch): 🧪 add test cases for toString rounding (#491)

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
albertms10 · May 12, 2024 · 5fcc757 · 5fcc757
1 parent 1d0a073
commit 5fcc757
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -523,7 +523,7 @@ Or parse a `ClosestPitch` from a string:
 
 ```dart
 ClosestPitch.parse('A4'); // A4
-ClosestPitch.parse('A4+12.4'); // A4+12.4
+ClosestPitch.parse('A4+12.6'); // A4+13
 ClosestPitch.parse('E♭3-28'); // E♭3-28
 ```
 

diff --git a/example/main.dart b/example/main.dart
@@ -270,7 +270,7 @@ void main() {
   Note.g.flat.inOctave(5) - const Cent(8.236); // G♭5-8
 
   ClosestPitch.parse('A4'); // A4
-  ClosestPitch.parse('A4+12.4'); // A4+12.4
+  ClosestPitch.parse('A4+12.6'); // A4+13
   ClosestPitch.parse('E♭3-28'); // E♭3-28
 
   // In a nutshell

diff --git a/lib/src/note/closest_pitch.dart b/lib/src/note/closest_pitch.dart
@@ -98,7 +98,7 @@ class ClosestPitch {
   /// const Frequency(440).closestPitch().toString() == 'A4'
   /// const Frequency(228.9).closestPitch().toString() == 'A♯3-31'
   /// (Note.g.inOctave(2) + const Cent(2)).toString() == 'G2+2'
-  /// (Note.e.flat.inOctave(3) - const Cent(14)).toString() == 'E♭3-14'
+  /// (Note.e.flat.inOctave(3) - const Cent(14.6)).toString() == 'E♭3-15'
   /// ```
   @override
   String toString() {

diff --git a/test/src/note/closest_pitch_test.dart b/test/src/note/closest_pitch_test.dart
@@ -91,6 +91,12 @@ void main() {
 
     group('.toString()', () {
       test('returns the string representation of this ClosestPitch', () {
+        expect(ClosestPitch(Note.a.inOctave(-3)).toString(), 'A-3');
+        expect(
+          ClosestPitch(Note.f.sharp.inOctave(6), cents: const Cent(0.4))
+              .toString(),
+          'F♯6',
+        );
         expect(
           ClosestPitch(Note.a.inOctave(4), cents: const Cent(3.456)).toString(),
           'A4+3',