Skip to content

Commit

Permalink
refactor(enums): replace toText with native name getter (#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
albertms10 committed Mar 12, 2022
1 parent efb67e0 commit b740031
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 26 deletions.
1 change: 0 additions & 1 deletion lib/music_notes.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ part 'src/classes/note.dart';
part 'src/classes/relative_tonalities.dart';
part 'src/classes/tonality.dart';
part 'src/enums/accidentals.dart';
part 'src/enums/enums_to_string.dart';
part 'src/enums/intervals.dart';
part 'src/enums/modes.dart';
part 'src/enums/notes.dart';
Expand Down
2 changes: 1 addition & 1 deletion lib/src/classes/interval.dart
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class Interval implements MusicItem, Comparable<Interval> {
Interval get inverted => Interval(interval.inverted, quality.inverted);

@override
String toString() => '${quality.toText()} ${interval.toText()}';
String toString() => '${quality.name} ${interval.name}';

@override
bool operator ==(Object other) =>
Expand Down
2 changes: 1 addition & 1 deletion lib/src/classes/key_signature.dart
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class KeySignature {
final n =
i == iterations ? nModExcludeZero(number, notesValues) : notesValues;

list.add('$n × ${accidental!.increment(i - 1)!.toText()}');
list.add('$n × ${accidental!.increment(i - 1)!.name}');
}

return list.join(', ');
Expand Down
2 changes: 1 addition & 1 deletion lib/src/classes/note.dart
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ class Note implements MusicItem, Comparable<Note> {
@override
String toString() =>
note.toText() + (accidental != null ? ' ${accidental!.toText()}' : '');
note.name + (accidental != null ? ' ${accidental!.name}' : '');
@override
bool operator ==(Object other) =>
Expand Down
2 changes: 1 addition & 1 deletion lib/src/classes/tonality.dart
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class Tonality implements Comparable<Tonality> {
);

@override
String toString() => '${mode.toText()} $note';
String toString() => '${mode.name} $note';

@override
bool operator ==(Object other) =>
Expand Down
21 changes: 0 additions & 21 deletions lib/src/enums/enums_to_string.dart

This file was deleted.

0 comments on commit b740031

Please sign in to comment.