♻️ refactor(analysis): enable ignored lints (#197)

* ♻️ refactor(analysis): enable ignored lints * ♻️ refactor(enharmonic_note): remove unwanted method * ♻️ refactor(scale): add missing `@immutable` annotation
albertms10 · Jun 23, 2023 · f1706fe · f1706fe
1 parent 1e19d0f
commit f1706fe
Show file tree

Hide file tree

Showing 11 changed files with 9 additions and 4 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -69,11 +69,8 @@ analyzer:
     - dart_code_metrics
 
   errors:
-    avoid_equals_and_hash_code_on_mutable_classes: ignore
     public_member_api_docs: ignore
-    unused_element: ignore # See https://github.com/dart-lang/sdk/issues/49025
 
     # Style decisions
-    always_put_required_named_parameters_first: ignore
     always_use_package_imports: ignore
     sort_constructors_first: ignore
diff --git a/lib/src/harmony/chord.dart b/lib/src/harmony/chord.dart
@@ -1,5 +1,6 @@
 part of '../../music_notes.dart';
 
+@immutable
 class Chord<T extends Scalable<T>>
     with Chordable<Chord<T>>
     implements Transposable<Chord<T>> {

diff --git a/lib/src/harmony/chord_pattern.dart b/lib/src/harmony/chord_pattern.dart
@@ -1,5 +1,6 @@
 part of '../../music_notes.dart';
 
+@immutable
 class ChordPattern with Chordable<ChordPattern> {
   /// The intervals from the root note.
   final List<Interval> intervals;

diff --git a/lib/src/harmony/harmonic_function.dart b/lib/src/harmony/harmonic_function.dart
@@ -1,5 +1,6 @@
 part of '../../music_notes.dart';
 
+@immutable
 class HarmonicFunction {
   final List<ScaleDegree> scaleDegrees;
 

diff --git a/lib/src/interval/enharmonic_interval.dart b/lib/src/interval/enharmonic_interval.dart
@@ -2,6 +2,7 @@
 
 part of '../../music_notes.dart';
 
+@immutable
 final class EnharmonicInterval extends Enharmonic<Interval> {
   const EnharmonicInterval(super.semitones);
 

diff --git a/lib/src/note/enharmonic_note.dart b/lib/src/note/enharmonic_note.dart
@@ -1,5 +1,6 @@
 part of '../../music_notes.dart';
 
+@immutable
 final class EnharmonicNote extends Enharmonic<Note>
     implements Scalable<EnharmonicNote> {
   const EnharmonicNote(super.semitones)

diff --git a/lib/src/note/positioned_note.dart b/lib/src/note/positioned_note.dart
@@ -1,6 +1,7 @@
 part of '../../music_notes.dart';
 
 /// A note octave in the octave range.
+@immutable
 final class PositionedNote
     implements Comparable<PositionedNote>, Scalable<PositionedNote> {
   /// Which of the 12 notes inside the octave.

diff --git a/lib/src/scale/scale.dart b/lib/src/scale/scale.dart
@@ -1,5 +1,6 @@
 part of '../../music_notes.dart';
 
+@immutable
 class Scale<T extends Scalable<T>> implements Transposable<Scale<T>> {
   /// The [Scalable<T>] degrees that define this [Scale<T>].
   final List<T> degrees;

diff --git a/lib/src/scale/scale_degree.dart b/lib/src/scale/scale_degree.dart
@@ -1,5 +1,6 @@
 part of '../../music_notes.dart';
 
+@immutable
 class ScaleDegree implements Comparable<ScaleDegree> {
   final int ordinal;
   final int inversion;

diff --git a/lib/src/scale/scale_pattern.dart b/lib/src/scale/scale_pattern.dart
@@ -3,6 +3,7 @@ part of '../../music_notes.dart';
 /// A set of musical notes ordered by fundamental frequency or pitch.
 ///
 /// See [Scale (music)](https://en.wikipedia.org/wiki/Scale_(music)).
+@immutable
 final class ScalePattern {
   /// The interval steps that define this [ScalePattern].
   final List<Interval> intervalSteps;

diff --git a/lib/src/transposable.dart b/lib/src/transposable.dart
@@ -1,6 +1,5 @@
 part of '../music_notes.dart';
 
-@immutable
 // ignore: one_member_abstracts
 abstract interface class Transposable<T> {
   /// Returns a transposed [T] by [interval] from this [T].