refactor: Extract Frequency #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to separate concerns: converting the positioned note to a frequency, which could be done in different ways, e.g. equal tempered, pythagorean (these methods belong to PositionedNote), versus properties or functionality related to the frequency itself, such as isHumanAudible or a hypothetical .play() method. Closes #107
plammens
force-pushed
the
refactor/frequency
branch
from
0997434
to
4409f23
Compare
Pull Request Test Coverage Report for Build 4968630824
💛 - Coveralls |
albertms10
approved these changes
May 12, 2023
albertms10
reviewed
May 12, 2023
Co-authored-by: Albert Mañosa <albertmasa2@gmail.com>
plammens
force-pushed
the
refactor/frequency
branch
from
bcf5acc
to
2a42a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to separate concerns: converting the positioned note to a frequency, which could be done in different ways, e.g. equal tempered, pythagorean (these methods belong to PositionedNote),
versus properties or functionality related to the frequency itself, such as isHumanAudible or a hypothetical .play() method.
Closes #107