Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(base_notes): rename Notes → BaseNote #121

Merged
merged 3 commits into from May 14, 2023
Merged

refactor(base_notes): rename Notes → BaseNote #121

merged 3 commits into from May 14, 2023

Conversation

albertms10
Copy link
Owner

Closes #109

@albertms10 albertms10 added the refactor The code needs to be refactored label May 14, 2023
@albertms10 albertms10 self-assigned this May 14, 2023
@coveralls
Copy link

coveralls commented May 14, 2023 •
edited

Pull Request Test Coverage Report for Build 4974348547

  • 47 of 47 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 4974315042: 0.0%
Covered Lines: 483
Relevant Lines: 483
💛 - Coveralls

@albertms10 albertms10 merged commit 3032556 into main May 14, 2023
3 checks passed
@albertms10 albertms10 deleted the refactor/rename-notes-to-base-note branch May 14, 2023 20:38
@albertms10 albertms10 added this to the Road to 0.7 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored
Projects
None yet
Milestone
Road to 0.7
Development

Successfully merging this pull request may close these issues.

Rename Notes enum to BaseNote
2 participants
@albertms10 @coveralls