Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(note): add Tonality major and minor getters #124

Merged
merged 1 commit into from
May 14, 2023
Merged

feat(note): add Tonality major and minor getters #124

merged 1 commit into from
May 14, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented May 14, 2023 •
edited

Closes #108

@albertms10 albertms10 added enhancement New feature or request refactor The code needs to be refactored labels May 14, 2023
@albertms10 albertms10 self-assigned this May 14, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4974509280

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 4974402651: 0.0%
Covered Lines: 483
Relevant Lines: 483
💛 - Coveralls

@albertms10 albertms10 merged commit aec2a68 into main May 14, 2023
3 checks passed
@albertms10 albertms10 deleted the feat/add-note-tonality-major-minor-getters branch May 14, 2023 21:20
@albertms10 albertms10 linked an issue May 14, 2023 that may be closed by this pull request
Add Note.major, .minor getters that return a Tonality #108
Closed
@albertms10 albertms10 added this to the Road to 0.7 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
enhancement New feature or request refactor The code needs to be refactored
Projects
None yet
Milestone
Road to 0.7
Development

Successfully merging this pull request may close these issues.

Add Note.major, .minor getters that return a Tonality
2 participants
@albertms10 @coveralls