Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor(interval): rename shorter static constants #177

Merged
merged 3 commits into from Jun 11, 2023
Merged

♻️ refactor(interval): rename shorter static constants #177

merged 3 commits into from Jun 11, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Jun 11, 2023 •
edited

Nearly saving 400 lines of code 😅, and faster to type. 🎉

@albertms10 albertms10 added refactor The code needs to be refactored test The code needs to implement tests labels Jun 11, 2023
@albertms10 albertms10 added this to the Road to 0.9 milestone Jun 11, 2023
@albertms10 albertms10 self-assigned this Jun 11, 2023
@coveralls
Copy link

coveralls commented Jun 11, 2023 •
edited

Pull Request Test Coverage Report for Build 5237547872

  • 9 of 9 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5237539939: 0.0%
Covered Lines: 750
Relevant Lines: 750
💛 - Coveralls

@albertms10 albertms10 modified the milestones: Road to 0.9, Road to 0.10 Jun 11, 2023
@albertms10 albertms10 merged commit f9b285d into main Jun 11, 2023
3 checks passed
@albertms10 albertms10 deleted the refactor/rename-shorter-interval-static-constants branch June 11, 2023 21:16
@albertms10 albertms10 changed the title refactor(interval): rename shorter static constants ♻️ refactor(interval): rename shorter static constants Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
Road to 0.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls