Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 feat(key_signature)!: rewrite based on a list of Notes #184

Merged
merged 1 commit into from Jun 18, 2023
Merged

💥 feat(key_signature)!: rewrite based on a list of Notes #184

merged 1 commit into from Jun 18, 2023

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests labels Jun 18, 2023
@albertms10 albertms10 self-assigned this Jun 18, 2023
@albertms10 albertms10 added this to the Road to 0.10 milestone Jun 18, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5303743251

  • 27 of 27 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5300303378: 0.0%
Covered Lines: 816
Relevant Lines: 816
💛 - Coveralls

@albertms10 albertms10 merged commit 16a4297 into main Jun 18, 2023
3 checks passed
@albertms10 albertms10 deleted the feat!/rewrite-key-signature-constructor-with-accidentals-list branch June 18, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
Road to 0.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls