Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(note): return correct distance for extreme Note spellings #187

Merged
merged 1 commit into from
Jun 18, 2023
Merged

🐛 fix(note): return correct distance for extreme Note spellings #187

merged 1 commit into from
Jun 18, 2023

Conversation

albertms10
Copy link
Owner

Fixes #149

@albertms10 albertms10 added bug Something isn't working refactor The code needs to be refactored test The code needs to implement tests labels Jun 18, 2023
@albertms10 albertms10 added this to the Road to 0.10 milestone Jun 18, 2023
@albertms10 albertms10 self-assigned this Jun 18, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5304485741

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5304286825: 0.0%
Covered Lines: 807
Relevant Lines: 807
💛 - Coveralls

@albertms10 albertms10 merged commit 612ecf1 into main Jun 18, 2023
3 checks passed
@albertms10 albertms10 deleted the fix/return-correct-distance-for-extreme-note-spellings branch June 18, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
bug Something isn't working refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
Road to 0.10
Development

Successfully merging this pull request may close these issues.

Note.fifthsDistanceWith does not return the correct distance for, e.g., Note.b.sharp
2 participants
@albertms10 @coveralls