Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 refactor(note)!: rewrite semitones starting from 0 instead of 1 #220

Merged
merged 2 commits into from Jul 22, 2023
Merged

💥 refactor(note)!: rewrite semitones starting from 0 instead of 1 #220

merged 2 commits into from Jul 22, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Jul 22, 2023 •
edited

Partially fixes #111

@albertms10 albertms10 added refactor The code needs to be refactored test The code needs to implement tests labels Jul 22, 2023
@albertms10 albertms10 added this to the Road to 0.11 milestone Jul 22, 2023
@albertms10 albertms10 self-assigned this Jul 22, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5631890192

  • 7 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5631886269: 0.0%
Covered Lines: 811
Relevant Lines: 811
💛 - Coveralls

@albertms10 albertms10 merged commit 091d839 into main Jul 22, 2023
3 checks passed
@albertms10 albertms10 deleted the refactor!/rewrite-zero-indexed-note-semitones branch July 22, 2023 17:30
@albertms10 albertms10 changed the title 💥 refactor(note): rewrite semitones starting from 0 instead of 1 💥 refactor(note)!: rewrite semitones starting from 0 instead of 1 Jul 22, 2023
@albertms10 albertms10 requested a review from plammens July 22, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plammens plammens Awaiting requested review from plammens

Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
Road to 0.11
Development

Successfully merging this pull request may close these issues.

Rewrite zero-indexed Note.semitones
2 participants
@albertms10 @coveralls