Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor(chord): reuse augmented, major, minor, diminished methods from ChordPattern #233

Merged
merged 2 commits into from
Aug 1, 2023
Merged

♻️ refactor(chord): reuse augmented, major, minor, diminished methods from ChordPattern #233

merged 2 commits into from
Aug 1, 2023

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added the refactor The code needs to be refactored label Aug 1, 2023
@albertms10 albertms10 added this to the Road to 0.12 milestone Aug 1, 2023
@albertms10 albertms10 self-assigned this Aug 1, 2023
@coveralls
Copy link

coveralls commented Aug 1, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5728610493

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5728605721: 0.0%
Covered Lines: 806
Relevant Lines: 806
💛 - Coveralls

@albertms10 albertms10 merged commit d8ba358 into main Aug 1, 2023
3 checks passed
@albertms10 albertms10 deleted the refactor/reuse-chord-augmented-methods-from-chord-pattern branch August 1, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored
Projects
None yet
Milestone
Road to 0.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls