Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ perf: rewrite map calls in favor of for loops #261

Merged
merged 1 commit into from
Aug 16, 2023
Merged

⚡ perf: rewrite map calls in favor of for loops #261

merged 1 commit into from
Aug 16, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Aug 16, 2023 •
edited
Loading

Before

ChordPattern.transposeBy(RunTime): 3.2461183769408115 us.

After

ChordPattern.transposeBy(RunTime): 2.856022571988714 us.

@albertms10 albertms10 added the refactor The code needs to be refactored label Aug 16, 2023
@albertms10 albertms10 added this to the Road to 0.12 milestone Aug 16, 2023
@albertms10 albertms10 self-assigned this Aug 16, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5884821411

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5884781115: 0.0%
Covered Lines: 831
Relevant Lines: 831
💛 - Coveralls

@albertms10 albertms10 merged commit ec2f2c1 into main Aug 16, 2023
3 checks passed
@albertms10 albertms10 deleted the perf/rewrite-map-calls-in-favor-or-for-loops branch August 16, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored
Projects
None yet
Milestone
Road to 0.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls