Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(equal_temperament)!: ♻️ rewrite octave divisions #304

Merged
merged 4 commits into from
Nov 7, 2023
Merged

refactor(equal_temperament)!: ♻️ rewrite octave divisions #304

merged 4 commits into from
Nov 7, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented Nov 7, 2023 •
edited

Continues #302

@albertms10 albertms10 added documentation Improvements or additions to documentation enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests labels Nov 7, 2023
@albertms10 albertms10 added this to the Road to 0.14 milestone Nov 7, 2023
@albertms10 albertms10 self-assigned this Nov 7, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6786287269

  • 18 of 18 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6768580319: 0.0%
Covered Lines: 903
Relevant Lines: 903
💛 - Coveralls

@albertms10 albertms10 merged commit 19ec3e6 into main Nov 7, 2023
3 checks passed
@albertms10 albertms10 deleted the refactor!/rewrite-equal-temperament-octave-steps branch November 7, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
documentation Improvements or additions to documentation enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
Road to 0.14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls