Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(interval): ♻️ rewrite Size as extension type #311

Merged
merged 27 commits into from Feb 21, 2024
Merged

refactor(interval): ♻️ rewrite Size as extension type #311

merged 27 commits into from Feb 21, 2024

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added the refactor The code needs to be refactored label Nov 24, 2023
@albertms10 albertms10 added this to the Road to 0.14 milestone Nov 24, 2023
@albertms10 albertms10 self-assigned this Nov 24, 2023
@albertms10 albertms10 marked this pull request as draft November 24, 2023 20:10
@albertms10 albertms10 removed this from the Road to 0.14 milestone Nov 24, 2023
@albertms10 albertms10 changed the title perf(interval): ⚡ rewrite Size as extension type refactor(interval): ♻️ rewrite Size as extension type Nov 24, 2023
@albertms10
feat(size): ✨ implement int to inherit common operators
247cf51
@albertms10
refactor(size): ♻️ remove overridden operators to allow const
0e6289a
@albertms10
refactor(size): ♻️ ensure simplified returns a copy
c41a43e
@albertms10
Merge branch 'main' into perf/rewrite-interval-size-as-extension-type
1239953
@albertms10
ci(analysis): 💚 use dev channel for Dart SDK
6c5ab81
@albertms10
refactor(size): ♻️ redeclare operator -()
a5ec1d3
@albertms10
style(size): 🎨 reformat file
216e31e
@albertms10
docs(size): 📖 fix wrong const usages in examples
516e124
@albertms10
refactor(size): ♻️ use Size.octave static constant
10d69a5
@albertms10
test(harmonic_function): 🧪 revert changes
bd1b0b6
@albertms10
refactor: ♻️ remove unnecessary .value access on Size
1423892
@albertms10
test(interval): 🧪 address wrong const usages
af107af
@albertms10
docs(README): 📖 update Interval usage with Size
ce38e11
@albertms10
build(pubspec): 🛠️ require Dart SDK 3.3.0-277.0.dev temporarily
38e78e6
@albertms10
Merge branch 'main' into perf/rewrite-interval-size-as-extension-type
62febc8
@albertms10
Merge branch 'main' into perf/rewrite-interval-size-as-extension-type
5279983
@albertms10
docs(size): 📖 reference octave where possible
6935275
@albertms10
Merge branch 'main' into perf/rewrite-interval-size-as-extension-type
0132035
@albertms10
Merge branch 'main' into perf/rewrite-interval-size-as-extension-type
e6d4d7b
@albertms10
fix(pitch): 🐛 use Size wrapper
1d8feb6
@albertms10
refactor(size): ♻️ move fromSemitones static method
f0cbf4c
@albertms10
refactor(size): ♻️ rename private _sizeToSemitones static const
ebf20d5
@albertms10
refactor(size): ♻️ remove redundant value accessor
7859389
@albertms10 albertms10 marked this pull request as ready for review February 21, 2024 23:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7996731092

Details

  • 0 of 62 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7996675964: 0.0%
Covered Lines: 1061
Relevant Lines: 1061
💛 - Coveralls

@albertms10 albertms10 merged commit 713a74e into main Feb 21, 2024
3 checks passed
@albertms10 albertms10 deleted the perf/rewrite-interval-size-as-extension-type branch February 21, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls