Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(note): ♻️ allow overriding accidental from NoteNotation #406

Merged

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added refactor The code needs to be refactored test The code needs to implement tests labels Feb 28, 2024
@albertms10 albertms10 added this to the Road to 0.17.0 milestone Feb 28, 2024
@albertms10 albertms10 self-assigned this Feb 28, 2024
@albertms10 albertms10 merged commit 3b2dc65 into main Feb 28, 2024
2 checks passed
@albertms10 albertms10 deleted the refactor/allow-overriding-accidental-from-note-notation branch February 28, 2024 00:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8073183986

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -1 of 7 (85.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 99.905%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/note/note.dart 5 6 83.33%
Totals Coverage Status
Change from base Build 8072981754: -0.1%
Covered Lines: 1055
Relevant Lines: 1056

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants