Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(scale_degree): ♻️ extract romanNumeral getter #423

Merged

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added refactor The code needs to be refactored test The code needs to implement tests labels Mar 7, 2024
@albertms10 albertms10 added this to the Road to 0.17.0 milestone Mar 7, 2024
@albertms10 albertms10 self-assigned this Mar 7, 2024
@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 8189368483

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8189279840: 0.0%
Covered Lines: 1067
Relevant Lines: 1067

💛 - Coveralls

@albertms10 albertms10 force-pushed the refactor/extract-scale-degree-roman-numeral-getter branch from a616e0e to 8ae612f Compare March 7, 2024 14:02
@albertms10 albertms10 merged commit 1b89686 into main Mar 7, 2024
3 checks passed
@albertms10 albertms10 deleted the refactor/extract-scale-degree-roman-numeral-getter branch March 7, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants