Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): 馃殮 move test to dev_dependencies #441

Merged
merged 1 commit into from Mar 14, 2024

Conversation

HussainTaj-W
Copy link
Contributor

Fixes #440

Description

Moving test to dev_dependecies solves the dependency resolution issue. And I think that's the correct place for this dependency anyway.

If this approach is unacceptable, an alternative would be to supply any for the package version. i.e.

test: any

How can this be tested

  1. Install flutter.
  2. Clone my fork https://github.com/HussainTaj-W/music_notes.
  3. Create a new flutter project.
  4. Add the following to your pubspec.yml.
    dependencies:
      music_notes:
        path: /path/to/project/music_notes
  5. Run
    flutter pub get
    
  6. Expect the dependencies to be resolved successfully.

PS: @albertms10 awesome project btw 馃憦

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8269563739

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8225581846: 0.0%
Covered Lines: 1120
Relevant Lines: 1120

馃挍 - Coveralls

@albertms10
Copy link
Owner

albertms10 commented Mar 14, 2024

Great! I totally agree on moving test under dev_dependencies instead.

Ready to be merged when you want鈥攖hanks!

@HussainTaj-W
Copy link
Contributor Author

Ready to be merged when you want

@albertms10, thanks for the quick review. I don't have the push access required to merge this PR. It'd be great to have this change in the next release. So feel free to merge it when you can.

@albertms10 albertms10 merged commit 8235ab9 into albertms10:main Mar 14, 2024
3 checks passed
@albertms10
Copy link
Owner

Apologies for the delay鈥攖he fix is now published as 0.17.1! 馃帀

@albertms10 albertms10 added the dependencies Pull requests that update a dependency file label Mar 17, 2024
@albertms10 albertms10 added this to the Road to 0.17.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

music_notes > 0.13.0 is incompatible with flutter 3.19 (latest stable)
3 participants