Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interval)!: replace Intervals enum with int value #45

Merged
merged 7 commits into from
Apr 13, 2023
Merged

feat(interval)!: replace Intervals enum with int value #45

merged 7 commits into from
Apr 13, 2023

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests labels Apr 12, 2023
@albertms10 albertms10 self-assigned this Apr 12, 2023
@coveralls
Copy link

coveralls commented Apr 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4684028746

  • 45 of 49 (91.84%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 91.72%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/interval/interval.dart 18 19 94.74%
lib/src/tonality/tonality.dart 0 1 0.0%
lib/src/note/notes.dart 2 4 50.0%
Totals Coverage Status
Change from base Build 4672951319: 0.4%
Covered Lines: 288
Relevant Lines: 314
💛 - Coveralls

@albertms10 albertms10 force-pushed the feat!/replace-intervals-enum-with-int-value branch from 775067c to cb6e4fa Compare April 12, 2023 01:17
@albertms10 albertms10 merged commit e050f55 into main Apr 13, 2023
@albertms10 albertms10 deleted the feat!/replace-intervals-enum-with-int-value branch April 13, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls