Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!(interval): ✨ add fromSemitones(int) and rename fromSizeAndSemitones factory constructors #476

Merged
merged 5 commits into from
May 13, 2024
Merged

feat!(interval): ✨ add fromSemitones(int) and rename fromSizeAndSemitones factory constructors #476

merged 5 commits into from
May 13, 2024

Conversation

plammens
Copy link
Collaborator

@plammens plammens commented Apr 2, 2024 •
edited

Closes #475

Rename:

  • fromQualitySemitones -> fromSizeAndQualitySemitones
  • fromSemitones -> fromSizeAndSemitones

Add:

  • fromSemitones(int)

@plammens plammens force-pushed the feat/interval-from-semitones branch from c992c05 to a2d6320 Compare April 2, 2024 12:08
@plammens plammens added the enhancement New feature or request label Apr 2, 2024
@coveralls
Copy link

coveralls commented Apr 2, 2024 •
edited

Pull Request Test Coverage Report for Build 9071125001

Details

  • 44 of 44 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9069428583: 0.0%
Covered Lines: 1177
Relevant Lines: 1177
💛 - Coveralls

@albertms10 albertms10 changed the title Add Interval.fromSemitones(int) feat!(interval): ✨ add fromSemitones(int) and rename fromSizeAndSemitones factory constructors Apr 10, 2024
albertms10
albertms10 approved these changes May 13, 2024
View reviewed changes
Copy link
Owner

@albertms10 albertms10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you very much for your contribution! 💎

@albertms10 albertms10 merged commit 451203c into main May 13, 2024
3 checks passed
@albertms10 albertms10 deleted the feat/interval-from-semitones branch May 13, 2024 23:23
@albertms10 albertms10 added this to the Road to 0.18 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertms10 albertms10 albertms10 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Road to 0.18
Development

Successfully merging this pull request may close these issues.

Interval constructor from just a number of semitones
3 participants
@plammens @coveralls @albertms10