Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ratio): ✨ add initial class representation and test cases #493

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat(ratio): ✨ add initial class representation and test cases #493

wants to merge 12 commits into from

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10
feat(mixed_num): ✨ add initial class representation and test cases
9c500b6 
Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10 albertms10 added enhancement New feature or request test The code needs to implement tests labels May 12, 2024
@albertms10 albertms10 self-assigned this May 12, 2024
@coveralls
Copy link

coveralls commented May 12, 2024 •
edited

Pull Request Test Coverage Report for Build 9573655102

Details

  • 46 of 46 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9573631624: 0.0%
Covered Lines: 1233
Relevant Lines: 1233
💛 - Coveralls

@albertms10
test: 🧪 shorten .parse() test descriptions
fc0a2af 
Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10
feat(mixed_num): 🔥 remove unused operator /
1899b4f 
Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10
test(mixed_num): 🧪 add test case for longer numbers
fa4286c 
Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10
feat(mixed_num): 🔥 drop support for negative values
e11f99f 
Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10
refactor(mixed_num): ♻️ rename wholePart and make fractionPart pu…
3390fd9 
…blic

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10 albertms10 added this to the Road to 0.19 milestone May 14, 2024
@albertms10 albertms10 changed the title feat(mixed_num): ✨ add initial class representation and test cases feat(ratio): ✨ add initial class representation and test cases Jun 18, 2024
@albertms10
feat(ratio): ✨ allow negative numbers in fromDouble factory constru…
35fa330 
…ctor

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10
Merge branch 'main' into feat/add-mixed-num-class-representation
c0d4ea0 
Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10
test(ratio): 🧪 use Ratio.zero whenever possible
8c38fff 
Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
enhancement New feature or request test The code needs to implement tests
Projects
None yet
Milestone
Road to 0.19
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls