Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: 💥 make comparator operators agree with compareTo and == #498

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented May 13, 2024

Fixes #477.

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10 albertms10 added enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests labels May 13, 2024
@albertms10 albertms10 self-assigned this May 13, 2024
@albertms10 albertms10 requested a review from plammens May 13, 2024 22:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9070931255

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9069428583: 0.0%
Covered Lines: 1156
Relevant Lines: 1156

💛 - Coveralls

@albertms10 albertms10 added this to the Road to 0.19 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparators of Interval and Pitch do not agree with ==
2 participants