Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(notes): address intervalSize descending logic #54

Merged
merged 4 commits into from
Apr 15, 2023
Merged

refactor(notes): address intervalSize descending logic #54

merged 4 commits into from
Apr 15, 2023

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added bug Something isn't working refactor The code needs to be refactored test The code needs to implement tests labels Apr 15, 2023
@albertms10 albertms10 self-assigned this Apr 15, 2023
@coveralls
Copy link

coveralls commented Apr 15, 2023 •
edited

Pull Request Test Coverage Report for Build 4707090343

  • 6 of 9 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 92.813%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/note/notes.dart 4 7 57.14%
Totals Coverage Status
Change from base Build 4704922413: 0.3%
Covered Lines: 297
Relevant Lines: 320
💛 - Coveralls

@albertms10 albertms10 merged commit c56f6c8 into main Apr 15, 2023
2 checks passed
@albertms10 albertms10 deleted the refactor/address-interval-size-descending-logic branch April 15, 2023 10:36
albertms10 added a commit that referenced this pull request Apr 15, 2023
@albertms10
test(main): call Notes main function
1d86cb9 
Missing from #54
@albertms10 albertms10 mentioned this pull request Apr 15, 2023
Merged
albertms10 added a commit that referenced this pull request Apr 15, 2023
@albertms10
test(note): add test cases for difference (#55)
2c42346 
* test(note): add test cases for `difference`

* docs(note): add examples for `difference`

* test(main): call Notes `main` function

Missing from #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
bug Something isn't working refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls