Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace EnharmonicNote with Note for transposeBy #88

Merged
merged 3 commits into from May 6, 2023
Merged

refactor: replace EnharmonicNote with Note for transposeBy #88

merged 3 commits into from May 6, 2023

Conversation

albertms10
Copy link
Owner

@albertms10 albertms10 commented May 6, 2023 •
edited

Partially addresses #50.

@albertms10 albertms10 added bug Something isn't working refactor The code needs to be refactored test The code needs to implement tests labels May 6, 2023
@albertms10 albertms10 self-assigned this May 6, 2023
@albertms10 albertms10 changed the title Refactor/replace enharmonic note with note for transpose by refactor: replace EnharmonicNote with Note for transposeBy May 6, 2023
@coveralls
Copy link

coveralls commented May 6, 2023 •
edited

Pull Request Test Coverage Report for Build 4902944142

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 4902880448: 0.0%
Covered Lines: 431
Relevant Lines: 431
💛 - Coveralls

@albertms10 albertms10 merged commit db7d5cc into main May 6, 2023
3 checks passed
@albertms10 albertms10 deleted the refactor/replace-enharmonic-note-with-note-for-transpose-by branch May 6, 2023 18:08
@albertms10 albertms10 mentioned this pull request Oct 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
bug Something isn't working refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertms10 @coveralls