CMakeLists.txt: explicitly declare LONG_OUTPUT_NAMES and DISABLE_STATIC #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should come after cmake_minimum_required() and additional set(POLICY) commands as they could change behavior of other commands. |
Toralf noticed a minor infelicity in option declarations:
```
build $ cmake -DLONG_OUTPUT_NAMES=YES ..
CMake Warning:
Manually-specified variables were not used by the project:
LONG_OUTPUT_NAMES
```
Note, CMake complains here about "unused" LONG_OUTPUT_NAMES.
The option is used but not declares as user-tweakable via 'option()'.
This change adds declarations for variables used in Gentoo.
Reported-by: Toralf Förster
Bug: https://bugs.gentoo.org/659880
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
|
Moved option declarations below |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toralf noticed a minor infelicity in option declarations:
Note, CMake complains here about "unused" LONG_OUTPUT_NAMES.
The option is used but not declares as user-tweakable via 'option()'.
This change adds declarations for variables used in Gentoo.
Reported-by: Toralf Förster
Bug: https://bugs.gentoo.org/659880
Signed-off-by: Sergei Trofimovich slyfox@gentoo.org