Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding more tests and fixing minor issues #26

Merged
merged 22 commits into from
Oct 19, 2021
Merged

Conversation

albertodev01
Copy link
Owner

@albertodev01 albertodev01 commented Sep 1, 2021

Why?

I need to add more tests to the library to make it more robust and improve the eigenvalues algorithm.

Right now, to compute eigenvalues the library uses a not-so-stable algorithm. It just iterates the product or R x Q of the QR decomposition and returns items in the diagonal. This is correct but it's numerically unstable so we need Householder reflections and improvements

What?

  • I have implemented the EigenDecomposition<K, T extends Matrix<K>> type
  • Now rank() and eigenvalues() work correctly

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

Notes

This PR also includes the new 'Integrals' page of the Flutter example app (located at example/flutter_example).

There also is a BREAKING CHANGE since NumericalIntegration now requires the function via constructor (earlier it was passed to the integrate() function)

Checklist

  • I have provided a description of the proposed changes.
  • I added unit tests for all relevant code.
  • I added golden tests for all UI changes.
  • I added documentation for all relevant code.

@albertodev01 albertodev01 added bug Something isn't working documentation Improvements or additions to documentation labels Sep 1, 2021
@albertodev01 albertodev01 self-assigned this Sep 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #26 (a2a209a) into master (c888118) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #26    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           65        66     +1     
  Lines         2850      2975   +125     
==========================================
+ Hits          2850      2975   +125     
Impacted Files Coverage Δ
lib/src/algebraic/types/quadratic.dart 100.00% <ø> (ø)
.../src/interpolation/types/newton_interpolation.dart 100.00% <ø> (ø)
lib/src/system/types/gauss.dart 100.00% <ø> (ø)
...sitions/singular_value_decomposition/real_svd.dart 100.00% <ø> (ø)
lib/src/utils/math_utils.dart 100.00% <ø> (ø)
lib/src/algebraic/algebraic.dart 100.00% <100.00%> (ø)
lib/src/algebraic/types/durand_kerner.dart 100.00% <100.00%> (ø)
lib/src/algebraic/utils/algebraic_division.dart 100.00% <100.00%> (ø)
.../src/algebraic/utils/polynomial_long_division.dart 100.00% <100.00%> (ø)
lib/src/algebraic/utils/sylvester_matrix.dart 100.00% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c888118...a2a209a. Read the comment docs.

@albertodev01 albertodev01 merged commit b2a4aa5 into master Oct 19, 2021
@albertodev01 albertodev01 deleted the develop branch October 19, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants