-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adding more tests and fixing minor issues #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertodev01
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Sep 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 65 66 +1
Lines 2850 2975 +125
==========================================
+ Hits 2850 2975 +125
Continue to review full report at Codecov.
|
…te' to constructor
Adding analyzers to the Flutter example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
I need to add more tests to the library to make it more robust and improve the eigenvalues algorithm.
Right now, to compute eigenvalues the library uses a not-so-stable algorithm. It just iterates the product or R x Q of the QR decomposition and returns items in the diagonal. This is correct but it's numerically unstable so we need Householder reflections and improvements
What?
EigenDecomposition<K, T extends Matrix<K>>
typerank()
andeigenvalues()
work correctlyTypes of Changes
Notes
This PR also includes the new 'Integrals' page of the Flutter example app (located at
example/flutter_example
).There also is a BREAKING CHANGE since
NumericalIntegration
now requires the function via constructor (earlier it was passed to theintegrate()
function)Checklist