Adds split to Seq[Result]

Signed-off-by: Albert Pastrana <albert.pastrana@gmail.com>
albertpastrana · Apr 13, 2018 · c826a13 · c826a13
1 parent ba7c273
commit c826a13
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 8 deletions.
diff --git a/result/src/main/scala/uscala/result/Result.scala b/result/src/main/scala/uscala/result/Result.scala
@@ -114,6 +114,16 @@ object Result extends ResultFunctions {
           a <- fa
         } yield r += a
       }.map(_.result())
+
+    def split(implicit bfe : CanBuildFrom[Nothing, E, M[E]], bfa : CanBuildFrom[Nothing, A, M[A]]): (M[E], M[A]) = {
+      val be = bfe()
+      val ba = bfa()
+      xs.foreach {
+        case Ok(v) => ba += v
+        case Fail(e) => be += e
+      }
+      (be.result, ba.result)
+    }
   }
 
   /**

diff --git a/result/src/test/scala/uscala/result/ResultSpec.scala b/result/src/test/scala/uscala/result/ResultSpec.scala
@@ -284,15 +284,29 @@ class ResultSpec extends Specification with ScalaCheck {
     }
   }
 
-  "sequence for traversables" >> {
-    "should transform a Seq(Fail) into a Fail" >> prop { xs: Seq[Int] => xs.nonEmpty ==>
-      (xs.map(Result.fail).sequence must_=== Fail(xs.head))
-    }
-    "should transform a Seq(Ok) into an Ok(Seq)" >> prop { xs: Seq[Int] => xs.nonEmpty ==>
-      (xs.map(Result.ok).sequence must_=== Ok(xs))
+  "ops on traversables" >> {
+    "split" >> {
+      "should split a Seq[Result[E, A]] into a (Seq[E], Seq[A]) " >> prop { xs: Seq[Int] => xs.nonEmpty ==> {
+        val (fails, oks) = xs.map(x => if (x < 0) Fail(x) else Ok(x)).split
+        fails must contain(be_<(0)).foreach
+        oks must contain(be_>=(0)).foreach
+      }}
+      "should split an empty Seq into a (Seq.empty, Seq.empty)" >> {
+        val (fails, oks) = Seq.empty[Result[Int, String]].split
+        fails must_=== Seq.empty[Int]
+        oks must_=== Seq.empty[String]
+      }
     }
-    "should transform an empty Seq into an Ok(Seq.empty)" >> {
-      Seq.empty[Result[Int, String]].sequence must_=== Ok(Seq.empty[String])
+    "sequence" >> {
+      "should transform a Seq(Fail) into a Fail" >> prop { xs: Seq[Int] => xs.nonEmpty ==>
+        (xs.map(Result.fail).sequence must_=== Fail(xs.head))
+      }
+      "should transform a Seq(Ok) into an Ok(Seq)" >> prop { xs: Seq[Int] => xs.nonEmpty ==>
+        (xs.map(Result.ok).sequence must_=== Ok(xs))
+      }
+      "should transform an empty Seq into an Ok(Seq.empty)" >> {
+        Seq.empty[Result[Int, String]].sequence must_=== Ok(Seq.empty[String])
+      }
     }
   }