Fixes asString when query has 1 param with no value #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there was a key with no values in the query string, there was a implicit conversion from string to list that made the code compile but that messed up with the params. That way, this query string `?hello` would be translated into `?h&e&l&l&o`. Signed-off-by: Albert Pastrana <albert.pastrana@gmail.com>
|
@nathankleyn it would be great if you can take a look at this one :) |
1 similar comment
nathankleyn
requested changes
May 8, 2018
| @@ -69,40 +68,41 @@ class URLSpec extends Specification with ScalaCheck with TestData { | |||
| "path" >> { | |||
| "should decode the rawPath correctly" >> { | |||
| "when it has a space" >> { | |||
| URL("http://example.com/hello%20world/").map(_.path) must beASuccessfulTry(Some("/hello world/")) | |||
| URL("http://example.com/hello%20world/").map(_.path) must beASuccessfulTry(Option("/hello world/")) | |||
There was a problem hiding this comment.
Think both of these lines should still be Some?
There was a problem hiding this comment.
This is because Intellij, if I leave it as Some, then the line appears as a compilation error (even if it's not). So I have to either do what I did or leave as Some and add the type like this: beASuccessfulTry[Option[String]](Some("/hello world/")).
Can't remember where I got the numbers for the exponential backoff test, but after several intermitent failures I just checked what the min and max values should be and they are slightly different from what I got. With these new values the test should never fail. Signed-off-by: Albert Pastrana <albert.pastrana@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 194 194
Branches 1 1
=====================================
Hits 194 194
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was a key with no values in the query string,
there was a implicit conversion from string to list that
made the code compile but that messed up with the params.
That way, this query string
?hellowould be translatedinto
?h&e&l&l&o.Signed-off-by: Albert Pastrana albert.pastrana@gmail.com