Feature/2 error handling improvement #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging level for sending a GET request, adding headers to the request, and successful requests in the NetworkService class have been changed from info to debug level. This change will ensure that these actions are only logged under debug settings, reducing the volume of logs under normal circumstances.
The logging levels and messages in `TheOddsApi` class have been adjusted to increase clarity and informativeness. Furthermore, the `JsonSyntaxException` has been imported for potential future use. The changes mainly transition `info` level logging messages to `debug` level with more descriptive messaging, providing better visibility during debugging.
Updated the NetworkService to throw specific exceptions for API key errors and rate limit errors. Further added the necessary exception classes (ApiKeyException and RateLimitException) for clean error handling. This improves the debugging process by providing clear error messages.
Updated the NetworkService to throw specific exceptions for API key errors and rate limit errors. Further added the necessary exception classes (ApiKeyException and RateLimitException) for clean error handling. This improves the debugging process by providing clear error messages.
The import for JsonSyntaxException in TheOddsApi.java has been removed as it is not utilized in the file. This is part of a general clean-up to reduce unnecessary code and improve code readability.
ArieArya
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Improvements: