Skip to content

Commit

Permalink
Merge branch 'fix-uber-java-monorepo'
Browse files Browse the repository at this point in the history
* fix-uber-java-monorepo:
  Add test
  Alias java monorepo for sourcegraph correctly
  • Loading branch information
albertyw committed Apr 20, 2024
2 parents 8137656 + 619cb25 commit b7d07ca
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
7 changes: 6 additions & 1 deletion git_browse/sourcegraph.py
Expand Up @@ -44,7 +44,7 @@ def get_url(self, git_object: typedefs.GitObject) -> str:
repository_url = "%s%s/uber-code/%s" % (
UBER_SOURCEGRAPH_URL,
self.host,
self.repository.replace('/', '-'),
self.format_phabricator_repository(),
)
else:
repository_url = "%s%s/%s" % (
Expand Down Expand Up @@ -86,3 +86,8 @@ def file_url(
focus_object.identifier,
)
return repository_url

def format_phabricator_repository(self) -> str:
if self.repository == "lm/fievel":
return "java-code"
return self.repository.replace("/", "-")
15 changes: 15 additions & 0 deletions git_browse/tests/test_sourcegraph.py
Expand Up @@ -20,6 +20,12 @@ def setUp(self) -> None:
"asdf/qwer",
)
self.uber_obj.host_class = phabricator.PhabricatorHost
self.uber_obj_java = sourcegraph.SourcegraphHost(
typedefs.GitConfig("", "master"),
"code.uber.internal",
"lm/fievel",
)
self.uber_obj_java.host_class = phabricator.PhabricatorHost

def test_init(self) -> None:
self.assertEqual(self.obj.host, "github.com")
Expand Down Expand Up @@ -125,3 +131,12 @@ def test_uber_get_url_file(self) -> None:
sourcegraph.UBER_SOURCEGRAPH_URL
+ "code.uber.internal/uber-code/asdf-qwer/-/blob/zxcv",
)

def test_uber_java_code(self) -> None:
git_object = typedefs.FocusObject("zxcv")
url = self.uber_obj_java.get_url(git_object)
self.assertEqual(
url,
sourcegraph.UBER_SOURCEGRAPH_URL
+ "code.uber.internal/uber-code/java-code/-/blob/zxcv",
)

0 comments on commit b7d07ca

Please sign in to comment.