This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
After-job hook #30
Merged
After-job hook #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +33,8 @@ type Pool struct { | |||
| // exit is used to signal the pool to stop running the query loop | |||
| // and close the jobs channel | |||
| exit chan bool | |||
| // afterFunc is a function that gets called after each job. | |||
| afterFunc *func(*Job) | |||
There was a problem hiding this comment.
Correct me if I'm wrong, but I don't think this needs to be a pointer to a function? Functions are, by themselves, already nillable. See http://play.golang.org/p/1qA9c70wpJ.
There was a problem hiding this comment.
@albrow didn't know about that trick. Neat!
Yeah, that's probably not needed then.
|
Looks great. I'm going to merge this and include it in a new release, hopefully tonight. I'll likely make this 0.4.0 and push back features planned for 0.4.0 to 0.5.0. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to the pool that gets executed each time a job is finished. Such function can be useful for monitoring.
I thought about adding a full-fledged middleware chains first, but it would add a lot of complexity without too many benefits. This implementation gets a function which can accept a Job via (Pool).SetAfterFunc() and runs it each time a job is finished regardless of its status, passing the job to the function.
Also, I moved the job.finished assgnment before the error checks (worker.go:85); this way the timings are saved even when the job returned an error.
(resubmitted, previous PR: #29)