Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use double quotes for attributes #4

Merged
merged 1 commit into from
Sep 22, 2011
Merged

use double quotes for attributes #4

merged 1 commit into from
Sep 22, 2011

Conversation

andreif
Copy link

@andreif andreif commented Sep 13, 2011

Double quotes in attributes seem to be more commonly used than single ones, and work better IMO

%tag{this:"doesn't work well"}
<tag this='doesn&quot;t work well'></tag>

doesn"t work well

albsen added a commit that referenced this pull request Sep 22, 2011
@albsen
Merge pull request #4 from andreif/feature-double_quotes
d066c7a 
use double quotes for attributes
@albsen albsen merged commit d066c7a into albsen:master Sep 22, 2011
albsen added a commit that referenced this pull request Sep 23, 2011
@albsen
Revert "Merge pull request #4 from andreif/feature-double_quotes"
d13a45f 
This reverts commit d066c7a, reversing
changes made to 923e2bd.
because they break stuff like:
%link{ :href => '{{ STATIC_URL }}stylesheets/screen.css?{% now%"jSFYH:is" %}', :type => "text/css", :rel => "stylesheet" }/
@albsen
Copy link
Owner

albsen commented Sep 23, 2011

I had to revert this in d13a45f because it broke how some django templatetags expect attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andreif @albsen