Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added transform "RandomCropFromBorders" and support for BBox in ElasticTransform, GridDistortion, OpticalDistortion #476

Merged
merged 13 commits into from
Jul 29, 2022
Merged

Added transform "RandomCropFromBorders" and support for BBox in ElasticTransform, GridDistortion, OpticalDistortion #476

merged 13 commits into from
Jul 29, 2022

Conversation

ZFTurbo
Copy link
Contributor

@ZFTurbo ZFTurbo commented Nov 23, 2019

No description provided.

@ZFTurbo ZFTurbo changed the title Added transform "RandomCropFromBorders" Added transform "RandomCropFromBorders" and Added support for BBox in ElasticTransform, GridDistortion, OpticalDistortion Nov 23, 2019
@ZFTurbo ZFTurbo changed the title Added transform "RandomCropFromBorders" and Added support for BBox in ElasticTransform, GridDistortion, OpticalDistortion Added transform "RandomCropFromBorders" and support for BBox in ElasticTransform, GridDistortion, OpticalDistortion Nov 23, 2019
@Dipet
Copy link
Collaborator

Dipet commented Nov 24, 2019

Thanks for your PR. Please update the README as written here https://github.com/albumentations-team/albumentations#contributing

@Dipet
Copy link
Collaborator

Dipet commented Nov 25, 2019

Also update code using black black --config=black.toml

@vladserkoff
Copy link
Contributor

@ZFTurbo, could you also implement a mask_from_bbox as a function as well, as you've done with the bbox_for_mask. It would be really useful for other mask-only transforms.
P.S. I thinks it's better to rename bbox_for_mask to bbox_from_mask, makes more sense to me this way.

Dipet
Dipet requested changes Nov 27, 2019
View reviewed changes
albumentations/augmentations/transforms.py Outdated Show resolved Hide resolved
@ternaus
Copy link
Collaborator

ternaus commented Jan 14, 2020

@ZFTurbo could you please rebase on the current master?

@IlyaOvodov
Copy link
Contributor

People! Somebody remove blank line at end of file functional.py to fix tests and merge it! Very usefull PR!

@jonatanbarkan
Copy link

Hi, what happened to this PR? it is very useful

@Dipet Dipet added Need check Need to check or recheck Awaiting merge and removed Branch conflict Need more info Need check Need to check or recheck labels Jul 29, 2022
@Dipet Dipet merged commit 1cd328b into albumentations-team:master Jul 29, 2022
Dipet added a commit that referenced this pull request Jul 29, 2022
@Dipet
Add RandomCropFromBorders and support for bbox in ElasticTransform …
033a5e7 
…from #476
@Dipet Dipet mentioned this pull request Jul 29, 2022
Merged
Dipet added a commit that referenced this pull request Aug 10, 2022
@Dipet
Add RandomCropFromBorders and support for bbox in ElasticTransform …
46e280f 
…from #476 (#1240)
@Dipet Dipet mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ternaus ternaus ternaus approved these changes

@Dipet Dipet Dipet approved these changes

@albu albu Awaiting requested review from albu

@BloodAxe BloodAxe Awaiting requested review from BloodAxe

@creafz creafz Awaiting requested review from creafz

Assignees
No one assigned
Labels
Awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ZFTurbo @Dipet @vladserkoff @ternaus @IlyaOvodov @jonatanbarkan @BloodAxe