Don't swallow mongo exceptions in the create_indexes rake task. Fixes …

…#1592

CHANGELOG.md

@@ -47,6 +47,9 @@ For instructions on upgrading to newer versions, visit
 
 ### Resolved Issues
 
+* \#1592 Don't swallow exceptions from index generation in the create_indexes
+  rake task.
+
 * \#1589 Allow assignment of empty array to HABTM when no documents are yet
   loaded into memory.
 

lib/rails/mongoid.rb

@@ -15,22 +15,21 @@ module Mongoid #:nodoc:
     #
     # @since 2.1.0
     def create_indexes(pattern)
-      logger = Logger.new($stdout)
       Dir.glob(pattern).each do |file|
         logger = Logger.new($stdout)
         begin
           model = determine_model(file)
-          if model
-            model.create_indexes
-            logger.info("Generated indexes for #{model}")
-          else
-            logger.info("Not a Mongoid parent model: #{file}")
-          end
         rescue => e
-          logger.error %Q{Failed to create indexes for #{model}:
+          logger.error(%Q{Failed to determine model from #{file}:
             #{e.class}:#{e.message}
             #{e.backtrace.join("\n")}
-          }
+          })
+        end
+        if model
+          model.create_indexes
+          logger.info("Generated indexes for #{model}")
+        else
+          logger.info("Not a Mongoid parent model: #{file}")
         end
       end
     end

spec/unit/rails/mongoid_spec.rb

@@ -8,6 +8,26 @@
 
   describe ".create_indexes" do
 
+    context "when an exception is raised" do
+
+      let(:model) do
+        stub
+      end
+
+      before do
+        Rails::Mongoid.expects(:determine_model).with(
+          "spec/app/models/account.rb"
+        ).returns(model)
+        model.expects(:create_indexes).raises(Mongo::MongoArgumentError)
+      end
+
+      it "is not swallowed" do
+        expect {
+          Rails::Mongoid.create_indexes("spec/app/models/**/*.rb")
+        }.to raise_error(Mongo::MongoArgumentError)
+      end
+    end
+
     context "with ordinary Rails models" do
 
       let(:model_paths) do